Skip to content

feat(pytorch): enable gfx125x for PyTorch release/2.11 builds#6122

Merged
rahulc-gh merged 1 commit into
mainfrom
users/rahulc/enable-gfx125x-pytorch_rel211
Jun 25, 2026
Merged

feat(pytorch): enable gfx125x for PyTorch release/2.11 builds#6122
rahulc-gh merged 1 commit into
mainfrom
users/rahulc/enable-gfx125x-pytorch_rel211

Conversation

@rahulc-gh

@rahulc-gh rahulc-gh commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

gfx125x support has been upstreamed via ROCm/pytorch#3346, so remove the exclusion from the release/2.11 matrix entry to enable multiarch builds for that branch.

Motivation

  • Removes the gfx125x exclusion from the release/2.11 PyTorch matrix entry

    Exclusions for release/2.9, release/2.10, release/2.12, and nightly remain in place as those branches do not have upstream support.

    ISSUE ID [issue] gfx1250 pytorch build temporary env vars #5833 (partially — for release/2.11).

    Unit Test

    python ./build_tools/github_actions/configure_multi_arch_ci.py locally with gfx125x label I can see - https://github.com/ROCm/TheRock/actions/runs/28133800797/job/83316100363?pr=6122#step:4:57

    Also There's no dedicated test file for configure_pytorch_release_matrix.py —
    the change is straightforward enough (removing a dict key) that it's covered by the existing matrix infrastructure tests.

    Test plan

    • Verify nightly CI triggers a release/2.11 PyTorch build that includes gfx125x in the matrix
    • Confirm other release branches still exclude gfx125x

gfx125x support has been upstreamed via ROCm/pytorch#3346, so remove
the exclusion from the release/2.11 matrix entry to enable multiarch
builds for that branch.
@rahulc-gh rahulc-gh added the gfx125x Issue/PR relates to gfx125x family label Jun 24, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: build_tools/github_actions/configure_pytorch_release_matrix.py; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jun 24, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@rahulc-gh rahulc-gh changed the title ISSUE ID #5833 feat(pytorch): enable gfx125x for PyTorch release/2.11 builds feat(pytorch): enable gfx125x for PyTorch release/2.11 builds Jun 24, 2026
@rahulc-gh

rahulc-gh commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Component test failures are not related to this changes, overriding and merging it to enabel 2.11 support. The CI fix to filter gfxarch for pytorch matrix is coming in #6082

@rahulc-gh rahulc-gh merged commit c677e87 into main Jun 25, 2026
354 of 395 checks passed
@rahulc-gh rahulc-gh deleted the users/rahulc/enable-gfx125x-pytorch_rel211 branch June 25, 2026 18:09
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gfx125x Issue/PR relates to gfx125x family Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants